Conversation
cquil11
requested review from
ankursingh-nv,
jgangani and
kedarpotdar-nv
as code owners
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you |
2 similar comments
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you |
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — straightforward revert of image version bump, config-only change.
Extended reasoning...
Overview
This PR reverts PR #800, which had updated the NVIDIA GPT-OSS vLLM image from v0.15.1 to v0.16.0-cu130. The changes are limited to two files: .github/configs/nvidia-master.yaml (3 image tag reverts across gptoss-fp4-b200-vllm, gptoss-fp4-h100-vllm, and gptoss-fp4-h200-vllm) and perf-changelog.yaml (removal of the corresponding changelog entry).
Security risks
None. This is a config-only change that reverts Docker image tags to a previously-used version. No code, authentication, permissions, or data handling is affected.
Level of scrutiny
Minimal scrutiny needed. This is a mechanical revert of a version bump in benchmark configuration files. The git history confirms this pattern — the revert commit d54901c is already on master, indicating this change has already been validated.
Other factors
No bugs were found by the automated bug hunting system. The PR timeline contains only automated bot comments with no outstanding reviewer feedback. The change is small, self-contained, and follows the established pattern of image version management in this repository.
1 participant
Reverts #800